Anki 2.1.24 Beta

Damien Elmes's Avatar

Damien Elmes

21 Mar, 2020 12:00 PM

Hi all,

A new beta is now available: https://betas.ankiweb.net

  1. 1 Posted by Guillem Palau-S... on 21 Mar, 2020 11:26 PM

    Guillem Palau-Salvà (contributor user)'s Avatar

    I've done a quick check and I have to say I am amazed with the new searching functionalities. Now my queries are much easier and shorter. Thank you so much !

  2. 2 Posted by Glutanimate on 22 Mar, 2020 05:46 AM

    Glutanimate's Avatar

    Wow, these changes are absolutely spectacular. Really excited about putting them to use. Thanks a lot, Damien!

    My only request would be to give add-on authors a few weeks to adjust (I assume you were planning on giving 2.1.24 a longer beta testing period anyway, giving the breadth of changes, but just in case). The changes to the Finder and removal of named sqlite bindings do affect Review Heatmap for instance, and I assume there are other popular add-ons that will also need to be adjusted.

  3. 3 Posted by John Smith on 22 Mar, 2020 06:50 AM

    John Smith's Avatar

    I can't build a filtered deck searching for "prop:due>-1 prop:due<1" while the same returns a list of cards in the deck browser.

  4. Support Staff 4 Posted by Damien Elmes on 22 Mar, 2020 07:34 AM

    Damien Elmes's Avatar

    Are you sure the cards aren't buried, suspended, or in a different filtered deck?

  5. Support Staff 5 Posted by Damien Elmes on 22 Mar, 2020 07:35 AM

    Damien Elmes's Avatar

    Glutanimate: yep, will likely be 3-4+ weeks like the last few betas

  6. 6 Posted by John Smith on 22 Mar, 2020 07:54 AM

    John Smith's Avatar

    This comment was split into a new discussion: Problem building filtered deck

    Yes. I emptied all filtered decks and started Anki without Addons.

  7. 7 Posted by br on 22 Mar, 2020 08:45 AM

    br's Avatar

    This might sound weird, but I don't get any error messages from my add-on code since updating. I updated from 2.1.22 to 2.1.24.
    The following does not produce any error message:
    showInfo("1")
    call_to_non_existant_fn()
    showInfo("2")

    prints "1" but not "2", no error message displayed.

  8. Support Staff 8 Posted by Damien Elmes on 22 Mar, 2020 11:30 AM

    Damien Elmes's Avatar

    I can't reproduce this - perhaps it's related to one of your other add-ons?

  9. 9 Posted by br on 22 Mar, 2020 03:35 PM

    br's Avatar

    You were right, I disabled everything else, and errors show up again. Thank you!

  10. 10 Posted by zjosua on 22 Mar, 2020 09:35 PM

    zjosua's Avatar

    Starting with 5debd3e0, opening/reloading the browser resets the sorting to "oldest to newest" when I am sorting by "Created".
    I can invert the order by clicking on the column header, but when I close and open it again, it's sorted oldest to newest again (the sort order indicator in the column header stays unchanged though).

    Most recent commit I've tested with is 427bf268.

  11. Support Staff 11 Posted by Damien Elmes on 23 Mar, 2020 10:48 AM

    Damien Elmes's Avatar

    Beta 2 is now available.

    zjosua: thanks, should be fixed.

  12. 12 Posted by tossu on 23 Mar, 2020 06:06 PM

    tossu's Avatar

    Hi,

    I've been testing Anki 2.1.24 Beta 2, and the removal of named SQL bindings seems to be a common cause of trouble among add-ons. Although the workaround is trivial in most cases, is there any chance of having named bindings back?

    Even without named bindings, the assert in DBProxy._query catches valid queries that include a literal colon. In my case it was a '::' used as a hierarchial tag separator. I think the assert can be removed because calls with keyword arguments will fail anyway.

  13. Support Staff 13 Posted by Damien Elmes on 24 Mar, 2020 09:08 AM

    Damien Elmes's Avatar

    I've removed the ':' check in git, but I'm afraid named args probably won't come back - I did grep through all add-ons before making the change, and only about 10% are affected, and those that are are easily updated.

  14. Support Staff 14 Posted by Damien Elmes on 24 Mar, 2020 09:08 AM

    Damien Elmes's Avatar

    (that's 10% of add-ons making DB queries, not 10% of all add-ons)

  15. 15 Posted by John Smith on 26 Mar, 2020 10:47 AM

    John Smith's Avatar

    Getting a loading screen when I try to create a new field in a note which doesn't go away with all addons disabled on the latest beta. Demonstrated in the gif.

  16. Support Staff 16 Posted by Damien Elmes on 01 Apr, 2020 05:45 AM

    Damien Elmes's Avatar

    Thanks John, this should be fixed in beta 3 which I have just pushed out.

  17. 17 Posted by marreromarco on 01 Apr, 2020 08:18 AM

    marreromarco's Avatar

    This comment was split into a new discussion: Error loading collection

    Upgraded to latest Anki 2.1.24 (d3964603).

    HeatMap was disabled and Anki worked OK. After enabling it, Anki fails to start even if I press Shift while starting Anki to disable all add ons.

    I am using Linux Mint 19.3 XFCE
    ------------------

    Error
    An error occurred. Please use Tools > Check Database to see if that fixes the problem.
    If problems persist, please report the problem on our support site. Please copy and paste the information below into your report.
    Anki 2.1.24 (d3964603) Python 3.8.1 Qt 5.14.1 PyQt 5.14.1
    Platform: Linux
    Flags: frz=True ao=False sv=2
    Add-ons, last update check: 2020-04-01 12:49:12

    Traceback (most recent call last):
      File "aqt/main.py", line 468, in loadCollection
      File "aqt/main.py", line 604, in moveToState
      File "aqt/main.py", line 611, in _deckBrowserState
      File "aqt/deckbrowser.py", line 54, in show
      File "aqt/deckbrowser.py", line 109, in _renderPage
      File "anki/schedv2.py", line 275, in deckDueTree
      File "anki/schedv2.py", line 253, in deckDueList
      File "anki/schedv2.py", line 478, in _deckNewLimitSingle
      File "anki/decks.py", line 369, in confForDid
    TypeError: 'NoneType' object does not support item assignment

  18. 18 Posted by Houssam Salem on 01 Apr, 2020 07:28 PM

    Houssam Salem's Avatar

    I'm having an issue building a filtered deck with "prop:due>-3" in it. It's a different issue from the one above. The full search query is this:
    deck:"日本語文法辞典例文全集" is:due prop:due>-3

    It seems like it ignores the prop term entirely and returns everything that is due in the deck. It works correctly in 2.1.22.

  19. Support Staff 19 Posted by Damien Elmes on 02 Apr, 2020 10:10 AM

    Damien Elmes's Avatar

    Thanks for the report, a fix will be in the next beta. Using "(is:due)" instead of "is:due" should fix it for now.

  20. 20 Posted by Houssam Salem on 02 Apr, 2020 04:35 PM

    Houssam Salem's Avatar

    When searching in the browser with deck:current, it always uses the deck that was current when Anki was first started. If I click into another deck and open the browser, it still uses the first deck.

    On the home screen, the new current deck is correctly highlighted.

  21. Support Staff 21 Posted by Damien Elmes on 03 Apr, 2020 10:07 AM

    Damien Elmes's Avatar

    Thanks Houssam, a fix will be in the next beta.

  22. 22 Posted by zjosua on 03 Apr, 2020 08:09 PM

    zjosua's Avatar

    Show Duplicates doesn't seem to work for me in Version 2.1.24 (3b619c4c).
    When clicking the link, a browser with the correct query opens, but the results table is empty.

  23. 23 Posted by cfculhane on 06 Apr, 2020 12:14 AM

    cfculhane's Avatar

    Hi there, another bug (or potentially interface change) related to db queries:
    In glutanimate's review_heatmap, the db query was specified with a today= keyword argument, which now raises an exception , see https://github.com/glutanimate/review-heatmap/issues/67

    return self.col.db.all(cmd, today=self.col.sched.today)

    TypeError: all() got an unexpected keyword argument 'today'

    Removing the keyword argument resolves the issue.

  24. 24 Posted by Glutanimate on 06 Apr, 2020 01:01 AM

    Glutanimate's Avatar

    Thanks, Chris. I fixed this in RH’s master branch a couple of weeks ago. Still need to address another .24 compat issue with the finder, and then I’ll push a new beta.

    @Damien:
    Just out of curiosity, but why did we end up dropping named SQL arguments in the first place? I’m sure there is a good technical reason for it, it’s just that even if all affected add-ons are fixed ahead if time, it will still cause a lot of support requests (especially with RH and other add-ons with large user bases affected). Does the Rust implementation not support named args?

  25. 25 Posted by cfculhane on 06 Apr, 2020 01:08 AM

    cfculhane's Avatar

    Oops sorry forgot to check the master branch!

    Also, I think it's causing an issue in the Image Occlusion addon as well, editing card in place no longer works, instead, it's adding new cards - possibly from the same db query issue? Another user has noted the same issue: https://github.com/glutanimate/image-occlusion-enhanced/issues/137

    I did check for commits on this one and couldn't find anything

  26. Support Staff 26 Posted by Damien Elmes on 06 Apr, 2020 04:47 AM

    Damien Elmes's Avatar

    It does supported named mappings, but as mentioned above only ~ 10% of DB querying add-ons were using them, and the required changes are simple and will continue to work on older Anki versions.

Reply to this discussion

Internal reply

Formatting help / Preview (switch to plain text) No formatting (switch to Markdown)

Attaching KB article:

»

Attached Files

You can attach files up to 10MB

If you don't have an account yet, we need to confirm you're human and not a machine trying to post spam.

Keyboard shortcuts

Generic

? Show this help
ESC Blurs the current field

Comment Form

r Focus the comment reply box
^ + ↩ Submit the comment

You can use Command ⌘ instead of Control ^ on Mac